Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Player Tracking to use Lists #4086

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Updates the Player Tracking Guide to use Lists instead of the older Player Tracking functionality.

Still kept the Player Tracking docs, to be removed when that feature gets removed.

Which issue(s) this PR fixes:

Closes #3653

Special notes for your reviewer:

Updates the Player Tracking Guide to use Lists instead of the older
Player Tracking functionality.

Still kept the Player Tracking docs, to be removed when that feature
gets removed.

Closes googleforgames#3653
@markmandel markmandel added the kind/feature New features for Agones label Jan 8, 2025
@markmandel markmandel requested a review from igooch January 8, 2025 22:38
@github-actions github-actions bot added kind/documentation Documentation for Agones size/M labels Jan 8, 2025
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: deca9aa4-ed3d-4eb4-a478-c949e597691c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator Author

Flake:

Wait for job upgrade-test-runner to complete or fail on cluster gke-autopilot-upgrade-test-cluster-1-30
SuccessCriteriaMetCompleteSuccessCriteriaMetCompleteComplete/tmp/tmp.UbSLSmsBO3/standard-upgrade-test-cluster-1-29.log: Complete
/tmp/tmp.UbSLSmsBO3/standard-upgrade-test-cluster-1-31.log: SuccessCriteriaMet
/tmp/tmp.UbSLSmsBO3/standard-upgrade-test-cluster-1-30.log: Complete
error: timed out waiting for the condition on jobs/upgrade-test-runner
One of the upgrade tests pid 2261 from cluster log /tmp/tmp.UbSLSmsBO3/gke-autopilot-upgrade-test-cluster-1-29.log exited with a non-zero status 1.
Cleaning up any remaining running pids:

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: d0a812f8-dd2b-4efe-a2b1-131dc8ddf284

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator Author

e2e flake.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: e07bc9ab-e165-4cd8-be07-73bfaffd6b98

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4086/head:pr_4086 && git checkout pr_4086
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-30e85c9

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch igooch merged commit 97c1f51 into googleforgames:main Jan 9, 2025
4 checks passed
@markmandel markmandel deleted the docs/player-tracking-lists branch January 10, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Documentation for Agones kind/feature New features for Agones size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs | Integration Patterns: Update Allocating based on GameServer Player Capacity to use Lists
3 participants