Move construction of kerning and mark structures to feed to fea-rs into separate jobs that can run in parallel #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
commented
Nov 11, 2023
rsheeter
force-pushed
the
threads
branch
3 times, most recently
from
43e8c0d to
9ea4457
Compare
rsheeter
force-pushed
the
t2
branch
4 times, most recently
from
f9a86af to
d462992
Compare
rsheeter
changed the title
anthrotype
reviewed
Nov 15, 2023
anthrotype
reviewed
Nov 15, 2023
Co-authored-by: Cosimo Lupo <[email protected]>
anthrotype
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build a structure that converts easily into a fea-rs structure because we are not able to build multiple partial delta sets and combine so we can't get var indices.
#571 may help with letting us build fea-rs structures without the intermediary.
hyperfine does not report a clear speedup. Emit timing suggests we create the potential for it but fail to exploit; lots of whitespace (idle) and seemingly delayed starts for the critical path. I need to take a detour to emojitown and then I can poke at that.
Pleasingly between not generating text to parse and splitting up the work fea is now not so dramatically the single long pole for Oswald (remember #456). Also nice to see fe kern, be marks, and hvar all run at once.