-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x-goog-spanner-request-id): add bases #2211
Merged
olavloite
merged 8 commits into
googleapis:main
from
odeke-em:x-goog-spanner-request-id-bases
Feb 9, 2025
Merged
feat(x-goog-spanner-request-id): add bases #2211
olavloite
merged 8 commits into
googleapis:main
from
odeke-em:x-goog-spanner-request-id-bases
Feb 9, 2025
+505
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kindly pinging @olavloite @surbhigarg92 to help bring this in as it is carved out of the larger PR #2205 and is isolated away from main code. |
olavloite
reviewed
Jan 9, 2025
e82d493
to
60204be
Compare
366e635
to
77ff03e
Compare
@surbhigarg92 @alkatrivedi @sakthivelmanii @harshachinta kindly help me trigger the bot runs. |
This change brings in the bases for x-goog-spanner-request-id by commit AtomicCounter and the various utilities plus some unit tests. Ripped out of PR googleapis#2205 Updates googleapis#2200
77ff03e
to
b277b36
Compare
Kind ping @surbhigarg92 @olavloite |
olavloite
approved these changes
Feb 9, 2025
Awesome and thank you @olavloite 🤘🏾👏🏿👏🏿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/nodejs-spanner API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings in the bases for x-goog-spanner-request-id by commit AtomicCounter and the various utilities plus some unit tests.
Ripped out of PR #2205
Updates #2200