Merge branch 'main' into owl-bot-copy-packages-google-shopping-mercha…

…nt-accounts
googleapis · Sep 27, 2024 · e133b52 · e133b52
2 parents 51bad9e + aff2a08
commit e133b52
Show file tree

Hide file tree

Showing 8 changed files with 23 additions and 8 deletions.
diff --git a/.github/scripts/close-invalid-link.cjs b/.github/scripts/close-invalid-link.cjs
@@ -41,7 +41,7 @@ module.exports = async ({ github, context }) => {
 
     if (isBugTemplate) {
         try {
-            const link = issue.data.body.split("\n")[18].match(/(https?:\/\/g?i?s?t\.?github.com\/.*)/);
+            const link = issue.data.body.split("\n")[18].match(/(https?:\/\/(gist\.)?github.com\/.*)/);
             const isValidLink = (await fetch(link)).ok;
             if (!isValidLink) {
             await closeIssue(github, owner, repo, number);

diff --git a/packages/google-cloud-dataform/README.md b/packages/google-cloud-dataform/README.md
@@ -44,7 +44,7 @@ Google APIs Client Libraries, in [Client Libraries Explained][explained].
 1.  [Select or create a Cloud Platform project][projects].
 1.  [Enable billing for your project][billing].
 1.  [Enable the Dataform API API][enable_api].
-1.  [Set up authentication with a service account][auth] so you can access the
+1.  [Set up authentication][auth] so you can access the
     API from your local workstation.
 
 ### Installing the client library
@@ -218,4 +218,4 @@ See [LICENSE](https://github.com/googleapis/google-cloud-node/blob/main/LICENSE)
 [projects]: https://console.cloud.google.com/project
 [billing]: https://support.google.com/cloud/answer/6293499#enable-billing
 [enable_api]: https://console.cloud.google.com/flows/enableapi?apiid=dataform.googleapis.com
-[auth]: https://cloud.google.com/docs/authentication/getting-started
+[auth]: https://cloud.google.com/docs/authentication/external/set-up-adc-local
diff --git a/packages/google-cloud-dataform/protos/protos.json b/packages/google-cloud-dataform/protos/protos.json
diff --git a/packages/google-cloud-dataform/samples/test/quickstart.js b/packages/google-cloud-dataform/samples/test/quickstart.js
@@ -44,6 +44,6 @@ describe('Quickstart', () => {
       `node ./quickstart.js projects/${projectId}/locations/us-central1`,
       {cwd}
     );
-    assert.deepStrictEqual(stdout, '');
+    assert(stdout);
   });
 });
diff --git a/packages/google-devtools-cloudbuild/protos/google/devtools/cloudbuild/v1/cloudbuild.proto b/packages/google-devtools-cloudbuild/protos/google/devtools/cloudbuild/v1/cloudbuild.proto
@@ -2228,15 +2228,18 @@ message BuildOptions {
     NONE = 4;
   }
 
-  // Default GCS log bucket behavior options.
+  // Default Cloud Storage log bucket behavior options.
   enum DefaultLogsBucketBehavior {
     // Unspecified.
     DEFAULT_LOGS_BUCKET_BEHAVIOR_UNSPECIFIED = 0;
 
     // Bucket is located in user-owned project in the same region as the
     // build. The builder service account must have access to create and write
-    // to GCS buckets in the build project.
+    // to Cloud Storage buckets in the build project.
     REGIONAL_USER_OWNED_BUCKET = 1;
+
+    // Bucket is located in a Google-owned project and is not regionalized.
+    LEGACY_BUCKET = 2;
   }
 
   // Requested hash for SourceProvenance.

diff --git a/packages/google-devtools-cloudbuild/protos/protos.d.ts b/packages/google-devtools-cloudbuild/protos/protos.d.ts
diff --git a/packages/google-devtools-cloudbuild/protos/protos.js b/packages/google-devtools-cloudbuild/protos/protos.js
diff --git a/packages/google-devtools-cloudbuild/protos/protos.json b/packages/google-devtools-cloudbuild/protos/protos.json