Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spanner): handle commit retry protocol extension for mux rw #11472

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

rahul2393
Copy link
Contributor

In a read-write transaction using a multiplexed session with (read/query + mutation) operations, the CommitResponse from the backend during the commit RPC may include a MultiplexedSessionRetry field (indicated by a precommit token). This field signals that the commit RPC should be retried once using the new precommit token. During this retry, mutations should not be resent, as they were already buffered in spanFE during the initial commit RPC call.

@rahul2393 rahul2393 requested review from a team as code owners January 20, 2025 09:11
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jan 20, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 20, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 20, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2025
spanner/transaction.go Show resolved Hide resolved
spanner/transaction_test.go Outdated Show resolved Hide resolved
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2025
@rahul2393 rahul2393 merged commit bf1e069 into main Jan 23, 2025
9 checks passed
@rahul2393 rahul2393 deleted the mux-commit-retry branch January 23, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants