Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): Async refresh dry run in parallel with sync refresh #11066

Merged
merged 17 commits into from
Dec 11, 2024

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Oct 31, 2024

Async refresh token and record any errors to debug_tags metrics with tag field set to "async_refresh_dryn_run"
Corresponding google-api-go-client PR: googleapis/google-api-go-client#2849

Fixes: b/372244283

This PR also updates conformance test Go version. Currently, conformance tests fail to run with error:

go: ../go.mod requires go >= 1.22.7 (running go 1.22.5; GOTOOLCHAIN=local)

@bhshkh bhshkh changed the base branch from main to feat/async-dry-run October 31, 2024 00:41
@bhshkh bhshkh changed the title More logs feat(bigtable): Async refresh dry run in parallel with sync refresh Oct 31, 2024
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Oct 31, 2024
@bhshkh bhshkh marked this pull request as ready for review November 18, 2024 18:56
@bhshkh bhshkh requested review from a team as code owners November 18, 2024 18:56
@bhshkh bhshkh changed the base branch from async-refresh-dry-run to main November 18, 2024 18:57
@bhshkh bhshkh requested a review from mutianf November 20, 2024 01:37
@bhshkh
Copy link
Contributor Author

bhshkh commented Nov 20, 2024

Facing #11161 when running multiple ReadRow operations in parallel. Will work on fixing it

bigtable/bigtable.go Outdated Show resolved Hide resolved
bigtable/metrics.go Outdated Show resolved Hide resolved
@bhshkh bhshkh enabled auto-merge (squash) December 4, 2024 19:43
@bhshkh bhshkh requested a review from mutianf December 4, 2024 19:43
@bhshkh
Copy link
Contributor Author

bhshkh commented Dec 4, 2024

Facing #11161 when running multiple ReadRow operations in parallel. Will work on fixing it

This has been fixed in oauth2adapt 0.2.6 . oauth2adapt is consumed in google.golang.org/api 0.210.0
So, I have updated go.mod to use google.golang.org/api 0.210.0

bigtable/metrics_util.go Outdated Show resolved Hide resolved
bigtable/metrics_util.go Outdated Show resolved Hide resolved
bigtable/metrics.go Outdated Show resolved Hide resolved
@bhshkh bhshkh requested a review from mutianf December 5, 2024 22:40
@bhshkh bhshkh merged commit 169e309 into googleapis:main Dec 11, 2024
7 of 9 checks passed
@bhshkh bhshkh deleted the feat/cbt-async-refresh-dry-run branch December 11, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants