cleanup(generator): move generator_config protos #14499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14499 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 2316 2316
Lines 207132 207132
=======================================
+ Hits 193864 193867 +3
+ Misses 13268 13265 -3 ☔ View full report in Codecov by Sentry. |
In the new location we can include the proto with angle brackets. We also know how to disable MSVC warnings for headers included via angle brackets. While the generator does not compile with MSVC, it is an easy proto to move.
coryan
force-pushed
the
cleanup-generator-move-generator-config-proto
branch
from
31d622c to
7109bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new location we can include the proto with angle brackets. We
also know how to disable MSVC warnings for headers included via angle
brackets. While the generator does not compile with MSVC, it is an easy
proto to move.
Part of the work for #14507
This change is