Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrappers load release dependencies if local dependencies do not match #1158

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Feb 4, 2025

Reworks the way wrapper Gemfiles reference local dependencies on GAPICs:

  • List the gapics in a variable that can be easily modified by the postprocessor if needed. (This needs to be paired with a corresponding modification to the postprocessor: fix: Update multiwrapper gemfile adjustment to work with generator 0.42.1 ruby-common-tools#360.)
  • For each gapic, check that the current local gem version is compatible with the wrapper's gemspec dependency. If not, fallback to the released gapic (and print a warning). This is to ensure wrapper tests continue to pass when doing a major version release of the gapic: the wrapper won't be able to load the new gapic version from HEAD because of the major version bump so it will fall back to testing against a compatible version from rubygems until the dependency is updated.

@dazuma dazuma merged commit c073304 into googleapis:main Feb 4, 2025
3 checks passed
@dazuma dazuma deleted the pr/wrapper-gemfile branch February 4, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants