Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing of qualifiers with colons #153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mateusnr
Copy link

The way column qualifiers are being parsed atm doesn't take into account those containing colon characters.

E.g.: given a column name abc:def:ghi, columnFilter() throws a bad format for column message, instead of returning a filter chain of abc and def:ghi

@mateusnr mateusnr requested review from a team, triplequark and igorbernstein2 as code owners June 30, 2023 21:17
@google-cla
Copy link

google-cla bot commented Jun 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant