Fix channel mismatch during normalization #126
Conversation
Previously, all channels in file b were normalized to the second channel in file a, instead of the correct, corresponding channel. This commit fixes that.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -246,7 +246,7 @@ int Main(int argc, char* argv[]) { | |||
| for (size_t channel_index = 0; channel_index < file_b->Info().channels; | |||
| ++channel_index) { | |||
| const EnergyAndMaxAbsAmplitude new_energy_and_max_abs_amplitude = | |||
| NormalizeAmplitude(file_a_max_abs_amplitude, | |||
There was a problem hiding this comment.
Nice, but now you can remove file_a_max_abs_amplitude completely, right?
There was a problem hiding this comment.
Yes, I do think so. Good catch.
There was a problem hiding this comment.
Great!
If you handle https://opensource.google/documentation/reference/cla, I can patch this PR to remove the variable completely if you don't want to do it yourself.
There was a problem hiding this comment.
I tried to patch the PR myself, and I think it worked. Learning a lot here :)
|
Thanks! It'll merge once the tests have passed. |
|
Why doesn't the build check complete... |
|
oops, now someone has to approve again... thought merging with main might trigger the build check to go through |
|
It's running now - let's hope it works :D |
Previously, all channels in file b were normalized to the second channel in file a, instead of the correct, corresponding channel. This commit fixes that.