Enable mac tests #77
Merged
Enable mac tests #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
Jan 11, 2024
| @@ -197,7 +197,7 @@ abstract class HmacSecretKey { | |||
| /// timing attacks. To validate signatures use [verifyBytes] or [verifyStream] | |||
| /// instead, these methods computes a signature and does a | |||
| /// fixed-time comparison. | |||
| /// {@template} | |||
| /// {@endtemplate} | |||
There was a problem hiding this comment.
For future reference please submit unrelated changes as individual PRs.
That makes it much easier to review and land them, and reduces the risk of conflicts, etc.
Small and fast is always preferable.
|
Hmm, maybe my run just timed out due to bad luck 🙈 or maybe you're just better at enabling tests than I am 🤣 Either way, let's merge it and ship this! |
|
Normally I delete commented out code. Maybe that left an impression, because if it hadn't worked, I would have started deleting it 🤫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the example app is not in the background during the test, all tests are green on my local mac. Furthermore I was able to successfully execute the tests.yml workflow on Github Actions without any relevant change. I hope that this can be reproduced on the main branch and #74 is fixed.
Finally, I have fixed a warning and adjusted the readme regarding the supported platforms.