Refactor HmacSecretKey Class #144
Conversation
|
part of #105 |
|
|
||
| @override | ||
| Future<HmacSecretKeyImpl> importRawKey(List<int> keyData, Hash hash, {int? length}) { | ||
| throw UnimplementedError(); |
There was a problem hiding this comment.
Can we throw throw UnimplementedError('Not implemented');
Or even just make a final _notImplemented = UnimplementedError('Not implemented'); inside impl_stub.dart, then we can use that in all the stubs.
Perhaps this is a follow up PR :D
There was a problem hiding this comment.
Updated to throw UnimplementedError('Not implemented'); as is in other files. Missed it here.
Or even just make a final _notImplemented = UnimplementedError('Not implemented'); inside impl_stub.dart, then we can use that in all the stubs.
Will update to this structure in a follow up PR
|
@HamdaanAliQuatil please rebase this, so we can run tests again, hopefully they'll pass :D |
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
HamdaanAliQuatil
force-pushed
the
refactor-hmac
branch
from
224c5aa to
d16483a
Compare
@jonasfj Done. The tests still didn't pass |
No description provided.