Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AesCbcSecretKey Class #141

Closed
wants to merge 13 commits into from
Closed

Update AesCbcSecretKey Class #141

wants to merge 13 commits into from

Conversation

HamdaanAliQuatil
Copy link
Collaborator

No description provided.

@HamdaanAliQuatil
Copy link
Collaborator Author

part of #105

@HamdaanAliQuatil HamdaanAliQuatil marked this pull request as draft July 24, 2024 07:34
@HamdaanAliQuatil HamdaanAliQuatil requested a review from jonasfj July 24, 2024 07:34
@HamdaanAliQuatil HamdaanAliQuatil requested a review from jonasfj July 25, 2024 08:13
jonasfj
jonasfj reviewed Jul 26, 2024
View reviewed changes
lib/src/impl_interface/impl_interface.dart Show resolved Hide resolved
lib/src/impl_ffi/impl_ffi.dart Outdated Show resolved Hide resolved
lib/src/impl_ffi/impl_ffi.aescbc.dart Outdated Show resolved Hide resolved
lib/src/impl_ffi/impl_ffi.aescbc.dart Show resolved Hide resolved
lib/src/impl_interface/impl_interface.aescbc.dart Show resolved Hide resolved
lib/src/impl_js/impl_js.aescbc.dart Outdated Show resolved Hide resolved
lib/src/impl_js/impl_js.dart Outdated Show resolved Hide resolved
lib/src/impl_stub/impl_stub.dart Outdated Show resolved Hide resolved
lib/src/webcrypto/webcrypto.dart Outdated Show resolved Hide resolved
@jonasfj
Copy link
Member

jonasfj commented Jul 26, 2024

I think we should consider flagging this as Ready for review, and then land it, and move one primitive at the time to the new architecture.

Otherwise, we'll be creating a huge PR that'll be nearly impossible to review.

HamdaanAliQuatil and others added 11 commits July 27, 2024 01:06
@HamdaanAliQuatil @jonasfj
Update lib/src/impl_interface/impl_interface.dart
d0845a8 
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@HamdaanAliQuatil @jonasfj
Update lib/src/impl_ffi/impl_ffi.dart
3b77a30 
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@HamdaanAliQuatil @jonasfj
Update lib/src/impl_ffi/impl_ffi.aescbc.dart
c99706f 
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@HamdaanAliQuatil @jonasfj
Update lib/src/impl_ffi/impl_ffi.aescbc.dart
2822bba 
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@HamdaanAliQuatil @jonasfj
Update lib/src/impl_ffi/impl_ffi.aescbc.dart
c53dd63 
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@HamdaanAliQuatil @jonasfj
Update lib/src/impl_interface/impl_interface.aescbc.dart
c616be9 
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@HamdaanAliQuatil @jonasfj
Update lib/src/impl_js/impl_js.aescbc.dart
84788fc 
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@HamdaanAliQuatil @jonasfj
Update lib/src/impl_js/impl_js.dart
89e90a5 
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@HamdaanAliQuatil @jonasfj
Update lib/src/impl_stub/impl_stub.dart
c49695d 
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@HamdaanAliQuatil @jonasfj
Update lib/src/webcrypto/webcrypto.dart
84eeab9 
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@HamdaanAliQuatil
test: add license headers
24c99b9
@HamdaanAliQuatil HamdaanAliQuatil marked this pull request as ready for review July 26, 2024 20:00
@HamdaanAliQuatil HamdaanAliQuatil requested a review from jonasfj July 26, 2024 20:00
@jonasfj
Copy link
Member

jonasfj commented Aug 13, 2024

Landed as part of #142 @HamdaanAliQuatil correct me if I'm wrong.

@jonasfj jonasfj closed this Aug 13, 2024
@HamdaanAliQuatil HamdaanAliQuatil deleted the refactor-aescbcsecretkey branch August 13, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HamdaanAliQuatil @jonasfj