Upgrade flutter_lints (#96)

* Upgrade flutter_lints * Replace `part of <library>` with `part of '<file>.dart'` * Avoid using deprecated property * Avoid `Pointer.elementAt` in favor of + operator
google · Mar 6, 2024 · 3656276 · 3656276
1 parent de8dbd9
commit 3656276
Showing 47 changed files with 52 additions and 53 deletions.
diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -490,7 +490,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "0.5.4"
+    version: "0.5.5"
   webdriver:
     dependency: transitive
     description:

diff --git a/lib/src/flutter/webcrypto_plugin.dart b/lib/src/flutter/webcrypto_plugin.dart
@@ -38,7 +38,7 @@ class WebcryptoPlugin {
     final channel = MethodChannel(
       'plugins.flutter.io/webcrypto',
       const StandardMethodCodec(),
-      registrar.messenger,
+      registrar,
     );
     final instance = WebcryptoPlugin();
     channel.setMethodCallHandler(instance.handleMethodCall);

diff --git a/lib/src/impl_ffi/impl_ffi.aes_common.dart b/lib/src/impl_ffi/impl_ffi.aes_common.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 Uint8List _aesImportRawKey(List<int> keyData) {
   if (keyData.length == 24) {

diff --git a/lib/src/impl_ffi/impl_ffi.aescbc.dart b/lib/src/impl_ffi/impl_ffi.aescbc.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 Future<AesCbcSecretKey> aesCbc_importRawKey(List<int> keyData) async =>
     _AesCbcSecretKey(_aesImportRawKey(keyData));

diff --git a/lib/src/impl_ffi/impl_ffi.aesctr.dart b/lib/src/impl_ffi/impl_ffi.aesctr.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 Future<AesCtrSecretKey> aesCtr_importRawKey(List<int> keyData) async =>
     _AesCtrSecretKey(_aesImportRawKey(keyData));

diff --git a/lib/src/impl_ffi/impl_ffi.aesgcm.dart b/lib/src/impl_ffi/impl_ffi.aesgcm.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 Future<AesGcmSecretKey> aesGcm_importRawKey(List<int> keyData) async =>
     _AesGcmSecretKey(_aesImportRawKey(keyData));

diff --git a/lib/src/impl_ffi/impl_ffi.digest.dart b/lib/src/impl_ffi/impl_ffi.digest.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 abstract class _Hash implements Hash {
   const _Hash();

diff --git a/lib/src/impl_ffi/impl_ffi.ec_common.dart b/lib/src/impl_ffi/impl_ffi.ec_common.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 /// Get `ssl.NID_...` from BoringSSL matching the given [curve].
 int _ecCurveToNID(EllipticCurve curve) {

diff --git a/lib/src/impl_ffi/impl_ffi.ecdh.dart b/lib/src/impl_ffi/impl_ffi.ecdh.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 Future<EcdhPrivateKey> ecdhPrivateKey_importPkcs8Key(
   List<int> keyData,

diff --git a/lib/src/impl_ffi/impl_ffi.ecdsa.dart b/lib/src/impl_ffi/impl_ffi.ecdsa.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 /// Get valid value for `jwk.alg` property given an [EllipticCurve] for ECDSA.
 String _ecdsaCurveToJwkAlg(EllipticCurve curve) {
@@ -116,11 +116,11 @@ Uint8List _convertEcdsaDerSignatureToWebCryptoSignature(
     // Dump R and S to return value.
     final out = scope<ffi.Uint8>(N * 2);
     _checkOpIsOne(
-      ssl.BN_bn2bin_padded(out.elementAt(0), N, R.value),
+      ssl.BN_bn2bin_padded(out + 0, N, R.value),
       fallback: 'internal error formatting R in signature',
     );
     _checkOpIsOne(
-      ssl.BN_bn2bin_padded(out.elementAt(N), N, S.value),
+      ssl.BN_bn2bin_padded(out + N, N, S.value),
       fallback: 'internal error formatting S in signature',
     );
     return out.copy(N * 2);
@@ -163,11 +163,11 @@ Uint8List? _convertEcdsaWebCryptoSignatureToDerSignature(
 
     final psig = scope.dataAsPointer<ffi.Uint8>(signature);
     _checkOp(
-      ssl.BN_bin2bn(psig.elementAt(0), N, R.value).address != 0,
+      ssl.BN_bin2bn(psig + 0, N, R.value).address != 0,
       fallback: 'allocation failure',
     );
     _checkOp(
-      ssl.BN_bin2bn(psig.elementAt(N), N, S.value).address != 0,
+      ssl.BN_bin2bn(psig + N, N, S.value).address != 0,
       fallback: 'allocation failure',
     );
 

diff --git a/lib/src/impl_ffi/impl_ffi.hkdf.dart b/lib/src/impl_ffi/impl_ffi.hkdf.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 Future<HkdfSecretKey> hkdfSecretKey_importRawKey(List<int> keyData) async =>
     _HkdfSecretKey(Uint8List.fromList(keyData));

diff --git a/lib/src/impl_ffi/impl_ffi.hmac.dart b/lib/src/impl_ffi/impl_ffi.hmac.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 /// Convert [data] to [Uint8List] and zero to [lengthInBits] if given.
 Uint8List _asUint8ListZeroedToBitLength(List<int> data, [int? lengthInBits]) {

diff --git a/lib/src/impl_ffi/impl_ffi.pbkdf2.dart b/lib/src/impl_ffi/impl_ffi.pbkdf2.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 Future<Pbkdf2SecretKey> pbkdf2SecretKey_importRawKey(List<int> keyData) async {
   return _Pbkdf2SecretKey(Uint8List.fromList(keyData));

diff --git a/lib/src/impl_ffi/impl_ffi.random.dart b/lib/src/impl_ffi/impl_ffi.random.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 void fillRandomBytes(TypedData destination) {
   return _Scope.sync((scope) {

diff --git a/lib/src/impl_ffi/impl_ffi.rsa_common.dart b/lib/src/impl_ffi/impl_ffi.rsa_common.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 _EvpPKey _importPkcs8RsaPrivateKey(List<int> keyData) {
   return _Scope.sync((scope) {

diff --git a/lib/src/impl_ffi/impl_ffi.rsaoaep.dart b/lib/src/impl_ffi/impl_ffi.rsaoaep.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 String _rsaOaepJwkAlgFromHash(_Hash hash) {
   if (hash == Hash.sha1) {
@@ -117,8 +117,7 @@ Future<Uint8List> _rsaOaepeEncryptOrDecryptBytes(
     ffi.Pointer<ffi.Size>,
     ffi.Pointer<ffi.Uint8>,
     int,
-  )
-      encryptOrDecryptFn,
+  ) encryptOrDecryptFn,
   List<int> data, {
   List<int>? label,
 }) async {

diff --git a/lib/src/impl_ffi/impl_ffi.rsapss.dart b/lib/src/impl_ffi/impl_ffi.rsapss.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 String _rsaPssJwkAlgFromHash(_Hash hash) {
   if (hash == Hash.sha1) {

diff --git a/lib/src/impl_ffi/impl_ffi.rsassapkcs1v15.dart b/lib/src/impl_ffi/impl_ffi.rsassapkcs1v15.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 String _rsassaPkcs1V15JwkAlgFromHash(_Hash hash) {
   if (hash == Hash.sha1) {

diff --git a/lib/src/impl_ffi/impl_ffi.utils.dart b/lib/src/impl_ffi/impl_ffi.utils.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_ffi;
+part of 'impl_ffi.dart';
 
 /// Wrapper around [EVP_PKEY] which attaches finalizer and ensure that the
 /// [ffi.Finalizable] is kept in scope while the [EVP_PKEY] is used.

diff --git a/lib/src/impl_js/impl_js.aescbc.dart b/lib/src/impl_js/impl_js.aescbc.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_js;
+part of 'impl_js.dart';
 
 const _aesCbcAlgorithm = subtle.Algorithm(name: 'AES-CBC');
 

diff --git a/lib/src/impl_js/impl_js.aesctr.dart b/lib/src/impl_js/impl_js.aesctr.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_js;
+part of 'impl_js.dart';
 
 const _aesCtrAlgorithm = subtle.Algorithm(name: 'AES-CTR');
 

diff --git a/lib/src/impl_js/impl_js.aesgcm.dart b/lib/src/impl_js/impl_js.aesgcm.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_js;
+part of 'impl_js.dart';
 
 const _aesGcmAlgorithm = subtle.Algorithm(name: 'AES-GCM');
 

diff --git a/lib/src/impl_js/impl_js.digest.dart b/lib/src/impl_js/impl_js.digest.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of impl_js;
+part of 'impl_js.dart';
 
 class _Hash implements Hash {
   final String _algorithm;

diff --git a/lib/src/impl_js/impl_js.ecdh.dart b/lib/src/impl_js/impl_js.ecdh.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_js;
+part of 'impl_js.dart';
 
 const _ecdhAlgorithmName = 'ECDH';
 

diff --git a/lib/src/impl_js/impl_js.ecdsa.dart b/lib/src/impl_js/impl_js.ecdsa.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_js;
+part of 'impl_js.dart';
 
 const _ecdsaAlgorithmName = 'ECDSA';
 

diff --git a/lib/src/impl_js/impl_js.hkdf.dart b/lib/src/impl_js/impl_js.hkdf.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_js;
+part of 'impl_js.dart';
 
 const _hkdfAlgorithmName = 'HKDF';
 

diff --git a/lib/src/impl_js/impl_js.hmac.dart b/lib/src/impl_js/impl_js.hmac.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_js;
+part of 'impl_js.dart';
 
 const _hmacAlgorithm = subtle.Algorithm(name: 'HMAC');
 

diff --git a/lib/src/impl_js/impl_js.pbkdf2.dart b/lib/src/impl_js/impl_js.pbkdf2.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_js;
+part of 'impl_js.dart';
 
 const _pbkdf2AlgorithmName = 'PBKDF2';
 

diff --git a/lib/src/impl_js/impl_js.random.dart b/lib/src/impl_js/impl_js.random.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of impl_js;
+part of 'impl_js.dart';
 
 void fillRandomBytes(TypedData destination) {
   try {

diff --git a/lib/src/impl_js/impl_js.rsaoaep.dart b/lib/src/impl_js/impl_js.rsaoaep.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_js;
+part of 'impl_js.dart';
 
 const _rsaOaepAlgorithmName = 'RSA-OAEP';
 

diff --git a/lib/src/impl_js/impl_js.rsapss.dart b/lib/src/impl_js/impl_js.rsapss.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_js;
+part of 'impl_js.dart';
 
 const _rsaPssAlgorithmName = 'RSA-PSS';
 

diff --git a/lib/src/impl_js/impl_js.rsassapkcs1v15.dart b/lib/src/impl_js/impl_js.rsassapkcs1v15.dart
@@ -14,7 +14,7 @@
 
 // ignore_for_file: non_constant_identifier_names
 
-part of impl_js;
+part of 'impl_js.dart';
 
 const _rsassaPkcs1V15Algorithm = subtle.Algorithm(name: 'RSASSA-PKCS1-v1_5');
 

diff --git a/lib/src/impl_js/impl_js.utils.dart b/lib/src/impl_js/impl_js.utils.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of impl_js;
+part of 'impl_js.dart';
 
 /// Convert [Stream<List<int>>] to [Uint8List].
 Future<Uint8List> _bufferStream(Stream<List<int>> data) async {

diff --git a/lib/src/webcrypto/webcrypto.aescbc.dart b/lib/src/webcrypto/webcrypto.aescbc.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 /// AES secret key for symmetric encryption and decryption using AES in
 /// _Cipher Block Chaining mode_ (CBC-mode), as described in

diff --git a/lib/src/webcrypto/webcrypto.aesctr.dart b/lib/src/webcrypto/webcrypto.aesctr.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 /// AES secret key for symmetric encryption and decryption using AES in
 /// _Counter mode_ (CTR-mode), as described in [NIST SP800-38A][1].

diff --git a/lib/src/webcrypto/webcrypto.aesgcm.dart b/lib/src/webcrypto/webcrypto.aesgcm.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 @sealed
 abstract class AesGcmSecretKey {

diff --git a/lib/src/webcrypto/webcrypto.digest.dart b/lib/src/webcrypto/webcrypto.digest.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 /// A cryptographic hash algorithm implementation.
 ///

diff --git a/lib/src/webcrypto/webcrypto.ecdh.dart b/lib/src/webcrypto/webcrypto.ecdh.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 @sealed
 abstract class EcdhPrivateKey {

diff --git a/lib/src/webcrypto/webcrypto.ecdsa.dart b/lib/src/webcrypto/webcrypto.ecdsa.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 @sealed
 abstract class EcdsaPrivateKey {

diff --git a/lib/src/webcrypto/webcrypto.hkdf.dart b/lib/src/webcrypto/webcrypto.hkdf.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 /// HKDF secret key (or password) for key derivation.
 ///

diff --git a/lib/src/webcrypto/webcrypto.hmac.dart b/lib/src/webcrypto/webcrypto.hmac.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 /// Key for signing/verifying with HMAC.
 ///

diff --git a/lib/src/webcrypto/webcrypto.pbkdf2.dart b/lib/src/webcrypto/webcrypto.pbkdf2.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 /// PBKDF2 secret key (or password) for key derivation.
 ///

diff --git a/lib/src/webcrypto/webcrypto.random.dart b/lib/src/webcrypto/webcrypto.random.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 /// Fill [destination] with cryptographically random values.
 ///

diff --git a/lib/src/webcrypto/webcrypto.rsaoaep.dart b/lib/src/webcrypto/webcrypto.rsaoaep.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 /// RSAES-OAEP private key for decryption of messages.
 ///

diff --git a/lib/src/webcrypto/webcrypto.rsapss.dart b/lib/src/webcrypto/webcrypto.rsapss.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 /// RSASSA-PSS private key for signing messages.
 ///

diff --git a/lib/src/webcrypto/webcrypto.rsassapkcs1v15.dart b/lib/src/webcrypto/webcrypto.rsassapkcs1v15.dart
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-part of webcrypto;
+part of 'webcrypto.dart';
 
 /// RSASSA-PKCS1-v1_5 private key for signing messages.
 ///

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -35,7 +35,7 @@ dev_dependencies:
   ffigen: ^9.0.0
   test: ^1.16.0
   yaml: ^3.0.0
-  flutter_lints: ^2.0.0
+  flutter_lints: ^3.0.1
   flutter_test:
     sdk: flutter