Improve reverse of string. #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing implementation of reverse was quadratic in the string length.
It's still a very problematic method because it doesn't understand Unicode characters, only code points, so it will mis-attribute combining marks in a reversed string, e.g., reverse("niño") would become "õnin".
|
This looks like it still writes "õnin" if I put it in dartpad... edit: I think that's what you were saying that the function is still problematic. |
Just run dartfmt again and it's LGTM by me. |
|
Yes, it doesn't fix the inherent problem in the function (which is that it doesn't work for real-life text strings). |
cbracken
approved these changes
Jun 7, 2017
|
Thanks! Filed #354 for the composed character ranges bug. |
jtmcdole
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation of reverse was quadratic in the string length.
It's still a very problematic method because it doesn't understand Unicode characters, only code points, so it will mis-attribute combining marks in a reversed string, e.g., reverse("niño") would become "õnin".