Remove code fixing features in JCC #13076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun skip |
oliverchang
reviewed
Feb 19, 2025
| WriteStdErrOut(fullCmdArgs, out, errstr) | ||
| fmt.Println("\nFix failure") | ||
| os.Exit(retcode) | ||
| os.Exit(0) |
There was a problem hiding this comment.
rather than only calling WriteStdErrOut and os.Exit() when retcode == 0, I think we need to do this in all cases?
There was a problem hiding this comment.
Good point, fixed.
|
/gcbrun skip |
oliverchang
reviewed
Feb 19, 2025
| fullCmdArgs := append([]string{bin}, newArgs...) | ||
| retcode, out, errstr := Compile(bin, newArgs) | ||
| WriteStdErrOut(fullCmdArgs, out, errstr) | ||
| os.Exit(0) |
There was a problem hiding this comment.
nit: os.Exit(retcode) ?
|
/gcbrun skip |
|
I did not update JCC binaries in gbucket, which are no longer in use. |
I have an important use in mind for the wrapper that isn't bug fixing. So thank you very much for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code fixing features are no longer required, but its main structure may be reused later.