chronos: Some fixes. #12995
Merged
chronos: Some fixes. #12995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oliverchang
commented
Jan 31, 2025
oliverchang
commented
- Improve logging to make it easier to derive log-based metrics on GCP.
- Compare compile times between replay and ccache and pick the better one.
- Improve logging to make it easier to derive log-based metrics on GCP. - Compare compile times between replay and ccache and pick the better one.
|
/gcbrun skip |
DonggeLiu
reviewed
Jan 31, 2025
|
|
||
| echo "Ccache compile time: ${A_TIME}" | ||
| if [[ -z "${REPLAY_WORKED}" || ${R_TIME} -gt ${A_TIME} ]]; then | ||
| if [ ${R_TIME} -gt ${A_TIME} ]; then |
There was a problem hiding this comment.
Is it a typo to check ${R_TIME} -gt ${A_TIME} twice?
There was a problem hiding this comment.
I wanted to log this specific case, which is why I'm repeating it here.
DonggeLiu
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.