-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fuzzer for normalize #81
Conversation
Nice, thanks for thinking of your reviewer! 🙂 Please squash the first two commits into one so that you move the code instead of copying and deleting it. The way I see it, the repository should look good at any commit and ir someone where to checkout the first commit, they would probably wonder about the duplicate code Also, please name the new module |
This refactoring is needed so that fuzzing code can import and test this logic.
I tested this fuzz target with changes from google#56 reverted and it does detect the panic.
a4bd702
to
8fdf4be
Compare
Sounds good. I removed the prefix |
Awesome, this looks great! |
Thanks! |
This addresses #57.
I am focusing on
mdbook-i18n-normalize
binary only in this PR. I will implement fuzzers for other binaries separately.In order to fuzz the logic, I had to move it out of binary to library. The first commit
copies the binary file without making any changes to make the review easier.
I confirmed that when running the new fuzzer against the version of the code
before #56 was merged,
it finds a failure pretty quickly.