Wrap all stl containers with a marl::StlAllocator #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-clayton
force-pushed
the
wrap-stl-alloc
branch
4 times, most recently
from
3f410ed to
cda1436
Compare
AWoloszyn
reviewed
Jun 5, 2020
| @@ -22,14 +22,11 @@ class AllocatorTest : public testing::Test { | |||
| }; | |||
|
|
|||
| TEST_F(AllocatorTest, AlignedAllocate) { | |||
There was a problem hiding this comment.
This looks like a perfect use for a parametrized test!
There was a problem hiding this comment.
Ack. I'll see if I can clean this up in another pass.
AWoloszyn
approved these changes
Jun 5, 2020
ben-clayton
force-pushed
the
wrap-stl-alloc
branch
6 times, most recently
from
541b46d to
56fc2b0
Compare
`StlAllocator` uses a `marl::Allocator` for performing the allocations, avoiding untracked heap allocations. Issue: google#131
Enabled `MARL_FATAL` and `MARL_ASSERT` even in debug builds.
ben-clayton
force-pushed
the
wrap-stl-alloc
branch
from
56fc2b0 to
fb533ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marl::StlAllocatoruses amarl::Allocatorfor performing the allocations, avoiding untracked heap allocations.Issue: #131