Skip to content

Commit

Permalink
Merge branch 'google:master' into rename-nongeographicalregion
Browse files Browse the repository at this point in the history
  • Loading branch information
KarolJakubKrawiec authored Nov 28, 2024
2 parents ae42ce6 + dfdc8e4 commit f916917
Show file tree
Hide file tree
Showing 178 changed files with 33,192 additions and 32,756 deletions.
42 changes: 42 additions & 0 deletions .github/workflows/osv-scanner-unified.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@

# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: OSV-Scanner

on:
pull_request:
branches: ["master"]
schedule:
- cron: "12 12 * * 1"
push:
branches: ["master"]

permissions:
# Required to upload SARIF file to CodeQL. See: https://github.com/github/codeql-action/issues/2117
actions: read
# Require writing security events to upload SARIF file to security tab
security-events: write
# Read commit contents
contents: read

jobs:
scan-scheduled:
if: ${{ github.event_name == 'push' || github.event_name == 'schedule' }}
# If you want to copy this config, highly suggest pinning this version to a release rather than tracking the main branch
uses: google/osv-scanner-action/.github/workflows/osv-scanner-reusable.yml@c80d3cb8d7bfabae9f047f6b8ea68792dd2ebcf6 # v1.9.0
scan-pr:
if: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }}
# If you want to copy this config, highly suggest pinning this version to a release rather than tracking the main branch
uses: google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml@c80d3cb8d7bfabae9f047f6b8ea68792dd2ebcf6 # v1.9.0
2 changes: 1 addition & 1 deletion FALSEHOODS.md
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ surprising how many false assumptions programmers continue to make about them.
countries a leading 0 is significant and forms part of the number itself
(see *A leading zero in numbers formatted for domestic usage can always be
discarded when dialing from abroad*). Moreover, a phone number may contain
other diallable characters (see *Phone numbers contain only digits*) or an
other dialable characters (see *Phone numbers contain only digits*) or an
extension portion, dialled after waiting for a tone.

**Tip:** Use the library to parse and format numbers to handle this
Expand Down
13 changes: 1 addition & 12 deletions FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -362,20 +362,9 @@ right thing if the phone number object is as intended.
@Mexico,
Mexico used to have such additional prefixes (1, 02, 045, ...) for dialling
mobile numbers internationally, fixed-line to mobile nationally.. As these
dialling patterns were deprecated, we have continued to maintain mobile and
dialling patterns were deprecated, we removed them but still maintain mobile and
fixed-line ranges at higher level, returning type as [`FIXED_LINE_OR_MOBILE`](#fixed_line_or_mobile)

### <a href="#mx_legacy_formats">Why Mexico (MX) numbers in older dialling formats are accepted as valid ones?</a>
Though library has stopped supporting below older dialling codes in the canonical
form and formatting results, we are lenient in parsing the number, i.e removing
all older codes.
- 1 -> in E.164 international diallings
- 01, 02, 044 and 045 -> for local/national diallings

This is because we found the older dialling codes supported even after deprecation
period, so we decided to support them for longer time. However, we will stop this as
part of [this issue](https://issuetracker.google.com/issues/205606725). More details there.

### <a name="#unsupported_regions">Why are Bouvet Island (BV), Pitcairn Island (PN), Antarctica (AQ) etc. not supported?</a>

We only support a country if:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Cream Sandwich).
The [Java demo](https://libphonenumber.appspot.com/) is updated with a slight
delay after the GitHub release.

Last demo update: v8.13.47.
Last demo update: v8.13.50.

Note: Even though the library (main branch/[maven release](https://repo1.maven.org/maven2/com/googlecode/libphonenumber/libphonenumber/8.12.56/))
is at v8.12.57, because of some deployment issues, we were unable to update the
Expand Down
27,038 changes: 13,537 additions & 13,501 deletions cpp/src/phonenumbers/lite_metadata.cc

Large diffs are not rendered by default.

26,138 changes: 13,089 additions & 13,049 deletions cpp/src/phonenumbers/metadata.cc

Large diffs are not rendered by default.

Loading

0 comments on commit f916917

Please sign in to comment.