Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a new by_regex option. #62

Merged
merged 21 commits into from
Jan 17, 2025
Merged

feat: Add a new by_regex option. #62

merged 21 commits into from
Jan 17, 2025

Conversation

JeffFaer
Copy link
Collaborator

No description provided.

README.md Outdated Show resolved Hide resolved
Copy link

@1e0ng 1e0ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this awesome change! Looking forward to this powerful feature in the new year.

README.md Show resolved Hide resolved
goldens/by_regex.in Show resolved Hide resolved
Copy link

@alzabo alzabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@KatrinaHoffert KatrinaHoffert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verrrry nice! I think this can actually resolve quite a few different issues that users have reported, thanks to how versatile regex is.

I kinda wonder if we should at some point support multi-line start stanzas, since as the options and their complexity grows, the keep-sorted start line is getting longer and longer.

goldens/by_regex.in Show resolved Hide resolved
goldens/by_regex.in Show resolved Hide resolved
README.md Show resolved Hide resolved
goldens/by_regex.in Show resolved Hide resolved
keepsorted/options.go Show resolved Hide resolved
keepsorted/options.go Show resolved Hide resolved
goldens/by_regex.err Outdated Show resolved Hide resolved
Base automatically changed from jfaer/joinedLines to main January 9, 2025 17:49
@JeffFaer
Copy link
Collaborator Author

I kinda wonder if we should at some point support multi-line start stanzas, since as the options and their complexity grows, the keep-sorted start line is getting longer and longer.

I'm definitely in favor of supporting multi-line start stanzas. I think that'd be useful by itself even if we were to implement some sort of keep-sorted configuration scheme where you could name long, complicated start stanzas to be re-used across a project

Copy link
Member

@KatrinaHoffert KatrinaHoffert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh at those regex examples for function names. Should be interesting what monstrosities people will come up with trying to use regex to parse non-regular languages.

keepsorted/options.go Show resolved Hide resolved
@JeffFaer JeffFaer merged commit ba6ba52 into main Jan 17, 2025
5 checks passed
@JeffFaer JeffFaer deleted the jfaer/by_regex branch January 17, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants