-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a new by_regex option. #62
Conversation
… CmpFunc type to make things a little more fluent.
…sitive when case=no.
This should minimize any performance penalty we're getting from the fact that joinedLines isn't cached.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this awesome change! Looking forward to this powerful feature in the new year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verrrry nice! I think this can actually resolve quite a few different issues that users have reported, thanks to how versatile regex is.
I kinda wonder if we should at some point support multi-line start stanzas, since as the options and their complexity grows, the keep-sorted start
line is getting longer and longer.
I'm definitely in favor of supporting multi-line start stanzas. I think that'd be useful by itself even if we were to implement some sort of keep-sorted configuration scheme where you could name long, complicated start stanzas to be re-used across a project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh at those regex examples for function names. Should be interesting what monstrosities people will come up with trying to use regex to parse non-regular languages.
No description provided.