feat: Allow default options to be customzied with a flag. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies things a bit, and sets us up to add a flag to override the default options.
JeffFaer
force-pushed
the
jfaer/flag_default_opts
branch
from
f082634 to
a6de573
Compare
KatrinaHoffert
approved these changes
Apr 9, 2024
JeffFaer
added a commit
that referenced
this pull request
Apr 9, 2024
This simplifies option parsing logic a bit, and sets us up to add a flag to override the default options (#35). I also tweaked most of the tests in keep_sorted_test to not rely on the default options at all and instead be more explicit about the behavior they need to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.