Add Spake parameter plumbing to Conscrypt #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cl: - Adds Key/TrustManagerFactories and Key/TrustManagers for Spake - Modifies OpenSSLParameters to accept Spake - Adds Spake setup within NativeSSL - Includes miscellaneous changes to make the above work - Adds tests for the above. TEST=atest SSLSocketTest/SpakeManagerFactoriesTest/SpakeKeyManagerParametersTest BUG=382233100 Change-Id: I5203a651fa74fe90cabd234bc2b1a94cfc9d3e88
prbprbprb
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Doesn't appear to build on OpenJDK: https://github.com/google/conscrypt/actions/runs/12807996512/job/35709784771?pr=1291
This cl: - Adds Key/TrustManagerFactories and Key/TrustManagers for Spake - Modifies OpenSSLParameters to accept Spake - Adds Spake setup within NativeSSL - Includes miscellaneous changes to make the above work - Adds tests for the above. TEST=atest SSLSocketTest/SpakeManagerFactoriesTest/SpakeKeyManagerParametersTest BUG=382233100 Change-Id: I5203a651fa74fe90cabd234bc2b1a94cfc9d3e88
This cl: - Adds Key/TrustManagerFactories and Key/TrustManagers for Spake - Modifies OpenSSLParameters to accept Spake - Adds Spake setup within NativeSSL - Includes miscellaneous changes to make the above work - Adds tests for the above. TEST=atest SSLSocketTest/SpakeManagerFactoriesTest/SpakeKeyManagerParametersTest BUG=382233100 Change-Id: I5203a651fa74fe90cabd234bc2b1a94cfc9d3e88
prbprbprb
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cl:
TEST=atest SSLSocketTest/SpakeManagerFactoriesTest/SpakeKeyManagerParametersTest BUG=382233100
Change-Id: I5203a651fa74fe90cabd234bc2b1a94cfc9d3e88