Key size in KPG.initialize() is bits, not bytes :)

google · Dec 14, 2023 · c05b8bd · c05b8bd
1 parent 2eb78fa
commit c05b8bd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/common/src/jni/main/cpp/conscrypt/native_crypto.cc b/common/src/jni/main/cpp/conscrypt/native_crypto.cc
@@ -1260,7 +1260,7 @@ static jbyteArray NativeCrypto_EVP_raw_X25519_private_key(
     }
 
     if (EVP_PKEY_get_raw_private_key(
-            pkey.get(), reinterpret_cast<uint8_t *>(bytes.get()),&key_length) == 0) {
+            pkey.get(), reinterpret_cast<uint8_t *>(bytes.get()), &key_length) == 0) {
         conscrypt::jniutil::throwExceptionFromBoringSSLError(env, "EVP_PKEY_get_raw_private_key");
         return nullptr;
     }

diff --git a/common/src/main/java/org/conscrypt/OpenSSLXDHKeyPairGenerator.java b/common/src/main/java/org/conscrypt/OpenSSLXDHKeyPairGenerator.java
@@ -47,7 +47,7 @@ public KeyPair generateKeyPair() {
 
     @Override
     public void initialize(int keysize, SecureRandom random) {
-        if (keysize != OpenSSLX25519Key.X25519_KEY_SIZE_BYTES) {
+        if (keysize != OpenSSLX25519Key.X25519_KEY_SIZE_BYTES * 8) {
             throw new IllegalArgumentException("Only X25519 supported");
         }
     }