Improve AdvertisingData type annotations #646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zxzxwu
commented
Feb 11, 2025
zxzxwu
commented
- Add overloads to provide better return type hints
- Make advertising data type enum so they can be considered constants
* Add overloads to provide better return type hints * Make advertising data type enum so they can be considered constants
barbibulle
approved these changes
Feb 14, 2025
| @@ -90,7 +90,7 @@ class BaseError(BaseBumbleError): | |||
|
|
|||
| def __init__( | |||
| self, | |||
| error_code: Optional[int], | |||
| error_code: int | None, | |||
There was a problem hiding this comment.
Using | for unions is only supported for Python >= 3.10, so we can't use it yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.