Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a BlockSvg.getStyle() method. #8722

Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat: Add a BlockSvg.getStyle() method. #8722

merged 2 commits into from
Jan 7, 2025

Conversation

gonfunko
Copy link
Contributor

@gonfunko gonfunko commented Jan 6, 2025

The basics

The details

Resolves

Fixes #8565

Proposed Changes

This PR adds a getStyle() method to BlockSvg, and updates the rest of core to not directly access the .style property.

@gonfunko gonfunko requested a review from a team as a code owner January 6, 2025 21:50
@github-actions github-actions bot added the PR: feature Adds a feature label Jan 6, 2025
@gonfunko gonfunko merged commit a42c2d1 into google:develop Jan 7, 2025
11 checks passed
@gonfunko gonfunko deleted the get-style branch January 7, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachel-fenichel rachel-fenichel rachel-fenichel approved these changes

Assignees

@rachel-fenichel rachel-fenichel

Labels
PR: feature Adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create and expose BlockSvg.getStyle()
2 participants
@gonfunko @rachel-fenichel