feat: Allow specifying the placeholder text of workspace comments. #8608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
force-pushed
the
comment-placeholders
branch
from
fa9ebf1 to
713f23c
Compare
cpcallen
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Seems like a good change. The only thing I wonder is if we should rename WORKSPACE_COMMENT_DEFAULT_TEXT to WORKSPACE_COMMENT_PLACEHOLDER_TEXT (and tweak its description in msg/messages.js) for clarity. But doing that should probably be held until we have a two-way connection with Translatewiki again, so could you file a bug about it?
1 task
|
Sure, filed #8609. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
This PR adds a
setPlaceholderText()method toCommentViewandRenderedWorkspaceCommentthat allows specifying the placeholder text for a comment. It also updates the workspace comment creation contextual menu item to set the default text as a placeholder instead of literal text so that users don't have to manually delete/type over it to write their comment.