Add some additional list functions #844
Conversation
| var functionName = Blockly.Lua.provideFunction_( | ||
| 'list_reverse', | ||
| ['function ' + Blockly.Lua.FUNCTION_NAME_PLACEHOLDER_ + '(l)', | ||
| ' local t = {}', |
There was a problem hiding this comment.
Rename these variables to be more descriptive.
There was a problem hiding this comment.
Sure. I just copied the variable names that are used in all the other Lua functions in this file.
|
Done. |
| @@ -1015,6 +1015,13 @@ Blockly.Msg.LISTS_SPLIT_TOOLTIP_SPLIT = 'Split text into a list of texts, breaki | |||
| /// https://github.com/google/blockly/wiki/Lists#make-text-from-list] for more information. | |||
| Blockly.Msg.LISTS_SPLIT_TOOLTIP_JOIN = 'Join a list of texts into one text, separated by a delimiter.'; | |||
|
|
|||
| /// url - Information describing reversing a list. | |||
| Blockly.Msg.LISTS_REVERSE_HELPURL = ''; | |||
| /// Reverse a list of items %1. | |||
There was a problem hiding this comment.
"block text - Title of block that returns a copy of a list (%1) with the order of items reversed."
| @@ -1015,6 +1015,13 @@ Blockly.Msg.LISTS_SPLIT_TOOLTIP_SPLIT = 'Split text into a list of texts, breaki | |||
| /// https://github.com/google/blockly/wiki/Lists#make-text-from-list] for more information. | |||
| Blockly.Msg.LISTS_SPLIT_TOOLTIP_JOIN = 'Join a list of texts into one text, separated by a delimiter.'; | |||
|
|
|||
| /// url - Information describing reversing a list. | |||
| Blockly.Msg.LISTS_REVERSE_HELPURL = ''; | |||
There was a problem hiding this comment.
Go ahead and fill this in as: https://github.com/google/blockly/wiki/Lists#reversing-a-list
When you submit, also make a new issue to create this wiki content. We can probably make you an editor for the wiki and would greatly appreciate help adding the docs for your new blocks there.
Unless you find a Wikipedia or similar description of reversing a list. That would be good, too.
There was a problem hiding this comment.
Same applies for each of the new text blocks.
| Blockly.Msg.LISTS_REVERSE_HELPURL = ''; | ||
| /// Reverse a list of items %1. | ||
| Blockly.Msg.LISTS_REVERSE_MESSAGE0 = 'reverse %1'; | ||
| /// tooltip - See [https://github.com/google/blockly/wiki/Lists#reversing-a-list]. |
There was a problem hiding this comment.
Until the wiki docs are created, this will not be sufficient for translators.
"tooltip - Short description for a block that reverses a copy of a list."
|
Requested rewordings have been made. |
Mirroring #830, this adds
The lists codegen unit tests pass in all five languages (once you remove the pre-exisiting PHP tests that are syntactically invalid).