chore: spiff up the keyboard navigation codelab. #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igationController is instantiated. Link to docs.
jubishop
changed the title
cpcallen
reviewed
Apr 28, 2023
There was a problem hiding this comment.
Overall looks like a good set of improvements. I have two overall comments:
- For clarity, I think it would be best to word all instructions in the imperative, without using "you"—so, "now do x", rather than "now you will do x". Keep use of "you" for observations that are not instructions. (I've noted a number of these individually, but I recommend giving the whole text a copy-edit with this suggestion in mind.)
- I think if we're changing renderers then we should also re-create the images, but feel free to leave both those for a subsequent PR if you wish (i.e. reverting the render change for now); the other changes here seem worthwhile on their own.
Co-authored-by: Christopher Allen <[email protected]>
Co-authored-by: Christopher Allen <[email protected]>
Co-authored-by: Christopher Allen <[email protected]>
Co-authored-by: Christopher Allen <[email protected]>
|
thanks @cpcallen , I just went back to geras for now. |
|
all language should be updated now. |
cpcallen
approved these changes
May 18, 2023
|
@jubishop: I don't believe you have commit access, so let me know if you're ready for this to go in. |
|
yes please, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows standards/patterns using in custom renderer/generator.
fixes: #1657