Retain type-use annotations such as @Nullable in generated builder setters.
#1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…setters. This handles a further case using the logic introduced by #1704. RELNOTES=Type-use annotations such as `@Nullable` are now better preserved in generated builder setter method parameters. Previously they could be lost in some circumstances, for example with `@Nullable T`. PiperOrigin-RevId: 699982315
copybara-service
bot
force-pushed
the
test_main_699721928
branch
from
8f754fd to
19a71a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retain type-use annotations such as
@Nullablein generated builder setters.This handles a further case using the logic introduced by #1704.
RELNOTES=Type-use annotations such as
@Nullableare now better preserved in generated builder setter method parameters. Previously they could be lost in some circumstances, for example with@Nullable T.