Add grey_firstElement() to examples #135
Conversation
| } | ||
|
|
||
| let description: DescribeToBlock = { (description: GREYDescription!) -> Void in | ||
| guard let description = description else { |
There was a problem hiding this comment.
Why is description sometimes nil?
There was a problem hiding this comment.
it can be empty but shouldn't be nil. You're supposed to append matcher's description to it.
There was a problem hiding this comment.
I'm getting exceptions when running description.appendText("first match") without the guard.
There was a problem hiding this comment.
There was a problem hiding this comment.
Nice, I agree! Opened #136
There was a problem hiding this comment.
I think we should close this or find another way to provide it or so until we fix that issue.
There was a problem hiding this comment.
I think it'd be better to merge since this is what people have to do right now? Then update once the bug is fixed.
There was a problem hiding this comment.
Update this as #137 is in?
There was a problem hiding this comment.
@bootstraponline, should the guard be removed now that your fix is in?
There was a problem hiding this comment.
@bootstraponline, should the guard be removed now that your fix is in?
yes, updated.
|
LGTM |
| When an application has exact duplicate elements (every attribute is the same, | ||
| including their hierarchy), then the correct fix is to update the app to avoid | ||
| duplicating the UI. When that's not possible, a workaround is to match on | ||
| the first element. |
There was a problem hiding this comment.
Instead of the first element, couldn't we generalize this to match on Nth element?
I believe that can be baked in to the API :)
There was a problem hiding this comment.
yeah, that's a great idea. I received similar feedback internally.
|
@bootstraponline - I feel that this would serve better as a first party API. Thoughts? |
agreed |
|
Closing in favor of implementing Nth element matcher in EarlGrey core. |
#132