Glossary Removal #1316
Closed
Glossary Removal #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirodkar
reviewed
May 28, 2020
AppFramework/Action/GREYActions.m
Outdated
| NSString *description = [NSString stringWithFormat: | ||
| @"Keyboard did not appear after tapping on an element." | ||
| @"Are you sure that tapping on this element will bring up the keyboard?" | ||
| @"\nElement: %@", element]; |
There was a problem hiding this comment.
NSString *description =
[NSString stringWithFormat:@"Keyboard did not appear after tapping on an element."
@"Are you sure that tapping on this element will bring up the keyboard?"
@"\nElement: %@", element];
tirodkar
reviewed
May 28, 2020
AppFramework/Action/GREYActions.m
Outdated
| return NO; | ||
| } | ||
| } | ||
|
|
||
| // If a position is given, move the text cursor to that position. | ||
| __block id firstResponder = nil; | ||
| __block NSDictionary<NSString *, NSString *> *errorGlossary = nil; | ||
| __block NSMutableString *description = nil; |
There was a problem hiding this comment.
__block NSMutableString<NSString *, NSString *>
tirodkar
reviewed
May 28, 2020
| NSString *description = [NSString stringWithFormat:@"Failed to find stepper buttons in stepper:" | ||
| @"%@", [stepper description]]; | ||
| I_GREYPopulateError(error, kGREYInteractionErrorDomain, | ||
| kGREYInteractionActionFailedErrorCode, description); |
chan-park
reviewed
Jun 1, 2020
AppFramework/Action/GREYActions.m
Outdated
| NSString *description = [NSString stringWithFormat: | ||
| @"Keyboard did not appear after tapping on an element." | ||
| @"Are you sure that tapping on this element will bring up the keyboard?" | ||
| @"\nElement: %@", element]; |
There was a problem hiding this comment.
Instead of newline for each items of the glossary, how about adding numbering, or bullet points? I feel like that would be easier and cleaner than adding spaces, as well as parsing (if we have to). What do you think?
willsaid-google
commented
Jun 5, 2020
| [reason appendFormat:@"Assertion with [Matcher] failed: UI [Element] failed to match " | ||
| @"the following matcher(s): [Mismatch]"]; | ||
| glossary[@"Matcher"] = [matcher description]; | ||
| glossary[@"Element"] = [element grey_description]; |
There was a problem hiding this comment.
Add these back in to the reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Glossary Removal from Earl Grey Error Handling:
Recently, glossary contents have not been used at all, although they sometimes contain needed information (such as, what was the picker and the column that failed?)
If the glossary contents were important to the user, i added them to the exception reason.
If they weren't, i removed the glossary contents.
I also removed the glossary properties on GREYError, and the user info dictionary property as well being passed into I_GREYErrorMake, and the GREYPopulateErrorNoted macro, all of which were complicating error handling and making errors harder to read.
Example 1, where important info was not being shown, before:
after:
Example 2
this time when the glossary contained too much info, before:
and after:
Of course, in this second example, a followup edit should remove the unnecessary Element Matcher key for this specific error code but that is outside the scope of the glossary removal.
Example 3 - Idling Resources
In this example, the output hasn't changed at all, although the glossary was removed.
Example 4 - Stepper
If the stepper buttons aren't found, before:
Notice how it wasn't printing out the Stepper that is included in the glossary.
After: