Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unary success test assertions for basic and quote replies #39

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Add unary success test assertions for basic and quote replies #39

merged 2 commits into from
Dec 12, 2023

Conversation

andrewheard
Copy link
Collaborator

  • Added assertions to the unary basic and quoted reply success cases.
  • Updated response JSON payloads to include role and finishReason (freshly fetched from the backend).

@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Dec 12, 2023
@andrewheard andrewheard requested a review from paulb777 December 12, 2023 20:46
paulb777
paulb777 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewheard andrewheard merged commit 095ebee into main Dec 12, 2023
8 checks passed
@andrewheard andrewheard deleted the ah/unary-success-basic-tests branch December 12, 2023 21:17
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @paulb777