Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apiVersion to RequestOptions #101

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Add apiVersion to RequestOptions #101

merged 1 commit into from
Feb 9, 2024

Conversation

andrewheard
Copy link
Collaborator

@andrewheard andrewheard commented Jan 31, 2024 •
edited
Loading

Added apiVersion to RequestOptions, which allows developers to optionally target a specific version of the API (for example, "v1beta"); defaults to "v1" if not specified.

@andrewheard andrewheard changed the title WIP Add apiVersion to RequestOptions Add apiVersion to RequestOptions Feb 9, 2024
@andrewheard andrewheard marked this pull request as ready for review February 9, 2024 20:22
@andrewheard andrewheard requested a review from paulb777 February 9, 2024 20:22
@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Feb 9, 2024
paulb777
paulb777 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the second bullet of the description be?

Defaults to "v1" but allows developers to optionally target the "v1beta" (or any other) API

Also, we should make sure a description like this ends up in the generated release notes.

@andrewheard
Copy link
Collaborator Author

Should the second bullet of the description be?

Defaults to "v1" but allows developers to optionally target the "v1beta" (or any other) API

Also, we should make sure a description like this ends up in the generated release notes.

@paulb777 Good call, updated the PR description to clarify that "v1beta" is just one example.

@andrewheard andrewheard merged commit 90a1c6a into main Feb 9, 2024
9 checks passed
@andrewheard andrewheard deleted the ah/api-version branch February 9, 2024 21:07
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @paulb777