Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double quotes for JSON object keys #612

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

westonruter
Copy link
Contributor

@westonruter westonruter commented Oct 26, 2024

Description of the change

Use double-quoted string instead of single-quoted string in JSON.

Motivation

The string 'code_execution' is unexpectedly single-quoted in a JSON string when it should be double-quoted. Apparently this still works for the API (as does not quoting the object key at all) but the Bash syntax highligher is confused and thinks that the 'code_execution' text is not part of the string.

image

Type of change

Choose one: Documentation

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Oct 26, 2024
Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thanks!

@MarkDaoust MarkDaoust merged commit c16df61 into google-gemini:main Oct 29, 2024
10 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants