Make genai use common #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few changes were required to get unit tests to work. Mostly: - Move GenerateContentRequest validation from the model to the APIController. It's better to centralize this logic - Throw exceptions at the APIController level rather than model Other changes were kept at a minimum to simplify review
davidmotson
approved these changes
Mar 18, 2024
davidmotson
reviewed
Mar 18, 2024
common/src/test/java/com/google/ai/client/generativeai/common/StreamingSnapshotTests.kt
Outdated
Show resolved
Hide resolved
davidmotson
reviewed
Mar 18, 2024
generativeai/src/main/java/com/google/ai/client/generativeai/GenerativeModel.kt
Outdated
Show resolved
Hide resolved
daymxn
reviewed
Mar 18, 2024
| arrayOf("/modelname", "/modelname"), | ||
| arrayOf("modifiedNaming/mymodel", "modifiedNaming/mymodel"), | ||
| ) | ||
| fun `TODO`() { |
There was a problem hiding this comment.
def should be done before we merge this tbh
There was a problem hiding this comment.
I've added a very basic set of tests to unblock us.
There's some repeated code for testing between common and genai, this is expected for now. A follow up PR will contain a "common-test" module to make it easier to share code among both SDKs.
daymxn
reviewed
Mar 19, 2024
Comment on lines
64
to
65
| * @property apiVersion the endpoint version to communicate with. | ||
| * @property timeout the maximum amount of time for a request to take in the initial exchange. |
There was a problem hiding this comment.
These are out of date now, as they were moved to RequestOptions
daymxn
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.