Add unit tests to common #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few changes were required to get unit tests to work. Mostly: - Move GenerateContentRequest validation from the model to the APIController. It's better to centralize this logic - Throw exceptions at the APIController level rather than model Other changes were kept at a minimum to simplify review
daymxn
approved these changes
Mar 18, 2024
common/src/main/kotlin/com/google/ai/client/generativeai/common/APIController.kt
Show resolved
Hide resolved
common/src/main/kotlin/com/google/ai/client/generativeai/common/APIController.kt
Show resolved
Hide resolved
common/src/main/kotlin/com/google/ai/client/generativeai/common/APIController.kt
Show resolved
Hide resolved
common/src/test/java/com/google/ai/client/generativeai/common/StreamingSnapshotTests.kt
Outdated
Show resolved
Hide resolved
| val responseList = responses.toList() | ||
| responseList.any { | ||
| it.candidates?.any { it.citationMetadata?.citationSources?.isNotEmpty() ?: false } | ||
| ?: false |
There was a problem hiding this comment.
You've used this structure of any at least 7 times in your tests. Tbh, I'm surprised it's not already apart of the stdlib, but might I suggest:
internal fun <T> Iterable<T>?.any(predicate: (T) -> Boolean): Boolean =
this?.let { it.any { predicate(it) } } ?: falseThere was a problem hiding this comment.
It does sound like a great idea... but it triggers a stackoverflow due to recursion
Caused by: java.lang.StackOverflowError
at com.google.ai.client.generativeai.common.util.KotlinKt.any(kotlin.kt:38)
There was a problem hiding this comment.
Ahh I see, this should fix it:
internal fun <T> Iterable<T>?.any(predicate: (T) -> Boolean): Boolean =
this?.firstNotNullOfOrNull(predicate) != null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.