Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#75] Fix: set default value for role in public Content class and builder #76

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

PatilShreyas
Copy link
Contributor

@PatilShreyas PatilShreyas commented Mar 2, 2024

Summary

  • Specify default value for role as a "user" in a public API class Content.
  • Added tests for the verification of conversion functions (from public class to internal class and vice versa).

Fixes: #75

@rlazo
Copy link
Collaborator

rlazo commented Mar 7, 2024

Hey @PatilShreyas thanks for your contribution. I only have one outstanding comment, which is to include the copyright notice in the header of the test file. Once that's in I'll be able to merge your change. Thanks!

@PatilShreyas
Copy link
Contributor Author

Hey @PatilShreyas thanks for your contribution. I only have one outstanding comment, which is to include the copyright notice in the header of the test file. Once that's in I'll be able to merge your change. Thanks!

Done. I thought it'd be applied automatically when I ran the ktfmtFormat gradle task. I just got to know about the applyLicense gradle task. Thanks!

@rlazo rlazo merged commit 5bb04e4 into google-gemini:main Mar 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v0.2.1] API Error 400: please use a valid role: user, model
2 participants