Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes into main branch #71

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Merge changes into main branch #71

merged 4 commits into from
Feb 28, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Feb 28, 2024

No description provided.

rlazo and others added 4 commits February 14, 2024 14:56
Instead of relying on the generic message to notify users that they are
trying to access the API from an unsupported location, this PR adds an
specific new exception that app developers can use.

Although the underlying mechanism is still string matching, abstracting
this into the SDK rather than forcing every developer to do it on their
own is still a win.
Googlers see [b/325447428](http://b/325447428)

Co-authored-by: Rosário P. Fernandes <[email protected]>
Instead of leaving it empty, we should default to "user".

---------

Co-authored-by: Daymon <[email protected]>
@rlazo rlazo requested review from daymxn and davidmotson February 28, 2024 14:12
@rlazo rlazo enabled auto-merge (squash) February 28, 2024 14:12
@rlazo rlazo merged commit 07db810 into main Feb 28, 2024
5 checks passed
@rlazo rlazo deleted the next-dev branch February 28, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants