Davidmotson.auto functions #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 30, 2024 14:36
includes a builder to make it easier to add functions DO NOT MERGE
…s, and added a type system for automated function calling
rlazo
reviewed
Feb 10, 2024
generativeai/src/main/java/com/google/ai/client/generativeai/type/BetaGenAiAPI.kt
Outdated
Show resolved
Hide resolved
generativeai/src/main/java/com/google/ai/client/generativeai/GenerativeModel.kt
Outdated
Show resolved
Hide resolved
generativeai/src/main/java/com/google/ai/client/generativeai/GenerativeModel.kt
Outdated
Show resolved
Hide resolved
generativeai/src/main/java/com/google/ai/client/generativeai/internal/util/conversions.kt
Outdated
Show resolved
Hide resolved
generativeai/src/main/java/com/google/ai/client/generativeai/type/FunctionDeclarations.kt
Show resolved
Hide resolved
Co-authored-by: Rodrigo Lazo Paz <[email protected]>
thatfiredev
reviewed
Feb 23, 2024
generativeai/src/main/java/com/google/ai/client/generativeai/type/RequestOptions.kt
Outdated
Show resolved
Hide resolved
daymxn
requested changes
Mar 6, 2024
generativeai/src/main/java/com/google/ai/client/generativeai/Chat.kt
Outdated
Show resolved
Hide resolved
generativeai/src/main/java/com/google/ai/client/generativeai/type/RequestOptions.kt
Show resolved
Hide resolved
generativeai/src/main/java/com/google/ai/client/generativeai/type/FunctionParameter.kt
Show resolved
Hide resolved
generativeai/src/main/java/com/google/ai/client/generativeai/type/Type.kt
Show resolved
Hide resolved
generativeai/src/main/java/com/google/ai/client/generativeai/internal/util/conversions.kt
Outdated
Show resolved
Hide resolved
generativeai/src/main/java/com/google/ai/client/generativeai/Chat.kt
Outdated
Show resolved
Hide resolved
ncooke3
reviewed
Mar 11, 2024
generativeai/src/main/java/com/google/ai/client/generativeai/type/FunctionDeclarations.kt
Outdated
Show resolved
Hide resolved
…hat.kt Co-authored-by: Daymon <[email protected]>
…hat.kt Co-authored-by: Daymon <[email protected]>
|
We don't need to change the copyright date in the headers. |
rlazo
reviewed
Mar 20, 2024
| @@ -63,7 +73,19 @@ val GenerativeViewModelFactory = object : ViewModelProvider.Factory { | |||
| val generativeModel = GenerativeModel( | |||
| modelName = "gemini-1.0-pro", | |||
| apiKey = BuildConfig.apiKey, | |||
| generationConfig = config | |||
| generationConfig = config, | |||
There was a problem hiding this comment.
Given the inconsistent behaviour handling the functions, IMO we should have a separate entry in the sample app for function calling. This will prevent the regular chat example from failing due to an unrelated issue.
There was a problem hiding this comment.
oh whoops, this was not an intended part of the commit. I was doing this for my own testing, please ignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE