Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Markdown support in text #30

Closed
wants to merge 3 commits into from

Conversation

mubashirpa
Copy link

No description provided.

Copy link

google-cla bot commented Jan 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mubashirpa LGTM, Thank you!

@thatfiredev thatfiredev requested a review from rlazo January 3, 2024 14:38
Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're currently having some discussions internally about this change, so I'm removing my approval for now.

An update will be posted here once a final decision has been made.

@rlazo
Copy link
Collaborator

rlazo commented Jan 3, 2024

Hi @mubashirpa, thanks for your contribution. I agree with you, making the sample app format markdown responses would make them look better. That being said, the focus of the sample app right now is to showcase how to interact with the models while being very simple and having minimal dependencies. We'll keep in mind the feature for the future as the app evolves, thanks!

@rlazo rlazo closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants