Davidmotson.code execution #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlazo
reviewed
Jun 27, 2024
common/src/main/kotlin/com/google/ai/client/generativeai/common/client/Types.kt
Show resolved
Hide resolved
common/src/main/kotlin/com/google/ai/client/generativeai/common/client/Types.kt
Show resolved
Hide resolved
rlazo
reviewed
Jun 27, 2024
common/src/test/resources/golden-files/unary/success-code-execution.json
Outdated
Show resolved
Hide resolved
rlazo
approved these changes
Jun 28, 2024
|
This is a very, very good opportunity to have executable parts, especially if multiple languages are supported (like Kotlin 🥇). |
andrewheard
reviewed
Jul 3, 2024
| @@ -71,6 +76,18 @@ data class FileData( | |||
|
|
|||
| @Serializable data class Blob(@SerialName("mime_type") val mimeType: String, val data: Base64) | |||
|
|
|||
| @Serializable data class ExecutableCode(val language: String, val code: String) | |||
|
|
|||
| @Serializable data class CodeExecutionResult(val outcome: Outcome, val output: String) | |||
There was a problem hiding this comment.
@rlazo output is an optional field in the proto. How about we decode this as "" if the field is omitted?
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
Co-authored-by: David Motsonashvili <[email protected]>
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
Co-authored-by: David Motsonashvili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.