Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make common parse lenient #179

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Make common parse lenient #179

merged 3 commits into from
Jun 12, 2024

Conversation

daymxn
Copy link
Collaborator

@daymxn daymxn commented Jun 12, 2024

Per b/346812151,

This updates the json parser in common to be lenient in its decoding. Otherwise, it can not properly decode json literals such as:

{
   "result": true
}

A test has been added to track this change as well.

@daymxn daymxn requested a review from rlazo June 12, 2024 18:43
@daymxn daymxn self-assigned this Jun 12, 2024
@daymxn daymxn merged commit f161052 into main Jun 12, 2024
6 checks passed
@daymxn daymxn deleted the daymon-make-common-parse-leniant branch June 12, 2024 19:13
daymxn added a commit that referenced this pull request Jun 12, 2024
Per [b/346812151](https://b.corp.google.com/issues/346812151),

This updates the json parser in common to be lenient in its decoding.
Otherwise, it can not properly decode json literals such as:
```json
{
   "result": true
}
```

A test has been added to track this change as well.
PatilShreyas pushed a commit to PatilShreyas/generative-ai-kmp that referenced this pull request Sep 21, 2024
Per [b/346812151](https://b.corp.google.com/issues/346812151),

This updates the json parser in common to be lenient in its decoding.
Otherwise, it can not properly decode json literals such as:
```json
{
   "result": true
}
```

A test has been added to track this change as well.
PatilShreyas pushed a commit to PatilShreyas/generative-ai-kmp that referenced this pull request Sep 21, 2024
Per [b/346812151](https://b.corp.google.com/issues/346812151),

This updates the json parser in common to be lenient in its decoding.
Otherwise, it can not properly decode json literals such as:
```json
{
   "result": true
}
```

A test has been added to track this change as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants