Simplify function calling #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test? While the feature in itself doesn't have a lot logic to test, the test will also help demonstrate how to use the feature in its new incarnation. |
rlazo
reviewed
Jun 14, 2024
generativeai/src/main/java/com/google/ai/client/generativeai/internal/util/conversions.kt
Show resolved
Hide resolved
generativeai/src/test/java/com/google/ai/client/generativeai/GenerativeModelTests.kt
Show resolved
Hide resolved
rlazo
approved these changes
Jun 17, 2024
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
Per [b/344929335](https://b.corp.google.com/issues/344929335), This simplifies our function calling to not ascertain types. As a byproduct, we also no longer provide a means to execute functions. Additional documentation has been provided to showcase new usage.
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
Per [b/344929335](https://b.corp.google.com/issues/344929335), This simplifies our function calling to not ascertain types. As a byproduct, we also no longer provide a means to execute functions. Additional documentation has been provided to showcase new usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/344929335,
This simplifies our function calling to not ascertain types. As a byproduct, we also no longer provide a means to execute functions. Additional documentation has been provided to showcase new usage.
This PR also fixes the following: