Add responseMimeType support #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatfiredev
reviewed
May 2, 2024
generativeai/src/main/java/com/google/ai/client/generativeai/type/GenerationConfig.kt
Show resolved
Hide resolved
rlazo
requested changes
May 2, 2024
generativeai/src/main/java/com/google/ai/client/generativeai/type/GenerationConfig.kt
Show resolved
Hide resolved
|
Please add tests |
rlazo
approved these changes
May 6, 2024
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
Per [b/338414499](https://b.corp.google.com/issues/338414499), This adds support for the `responseMimeType` property that was added to `GenerationConfig` of gemini. This PR also fixes the following: - [b/338415129](https://b.corp.google.com/issues/338415129) -> Hide leaked JSON property in common --------- Co-authored-by: Rodrigo Lazo <[email protected]>
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
Per [b/338414499](https://b.corp.google.com/issues/338414499), This adds support for the `responseMimeType` property that was added to `GenerationConfig` of gemini. This PR also fixes the following: - [b/338415129](https://b.corp.google.com/issues/338415129) -> Hide leaked JSON property in common --------- Co-authored-by: Rodrigo Lazo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/338414499,
This adds support for the
responseMimeTypeproperty that was added toGenerationConfigof gemini.This PR also fixes the following:
DO_NOT_MERGE -> Wait until idea iteration is complete