Add clientId parameter in common #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter is used to fill the `x-goog-api-client` header
daymxn
reviewed
Apr 3, 2024
common/src/main/kotlin/com/google/ai/client/generativeai/common/APIController.kt
Show resolved
Hide resolved
daymxn
approved these changes
Apr 3, 2024
davidmotson
approved these changes
Apr 3, 2024
thatfiredev
reviewed
Apr 3, 2024
| */ | ||
| class APIController | ||
| internal constructor( | ||
| private val key: String, | ||
| model: String, | ||
| private val requestOptions: RequestOptions, | ||
| httpEngine: HttpClientEngine | ||
| httpEngine: HttpClientEngine, | ||
| private val clientId: String |
There was a problem hiding this comment.
This field is named apiClient in Web - should we name it the same thing for consistency? I understand it's an internal field, so consistency shouldn't be a top priority.
There was a problem hiding this comment.
Makes sense, thanks for the heads up @thatfiredev See #108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is used to fill the
x-goog-api-clientheader