keep GenerativeModel's original parameter positions (#115)

It seems like the `tools` and `toolConfig` parameters were added before `requestOptions`, which could cause a breaking change because in the current version of the SDK the `RequestOptions` is in a different order (right after `safetySettings`). --------- Co-authored-by: Rodrigo Lazo <[email protected]>
google-gemini · Apr 9, 2024 · 753cb33 · 753cb33
1 parent 69b5610
commit 753cb33
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.changes/generativeai/beginner-car-club-airport.json b/.changes/generativeai/beginner-car-club-airport.json
@@ -0,0 +1 @@
+{"type":"MAJOR","changes":["Keep argument positions"]}
diff --git a/generativeai/src/main/java/com/google/ai/client/generativeai/GenerativeModel.kt b/generativeai/src/main/java/com/google/ai/client/generativeai/GenerativeModel.kt
@@ -81,10 +81,10 @@ internal constructor(
     apiKey: String,
     generationConfig: GenerationConfig? = null,
     safetySettings: List<SafetySetting>? = null,
+    requestOptions: RequestOptions = RequestOptions(),
     tools: List<Tool>? = null,
     toolConfig: ToolConfig? = null,
     systemInstruction: Content? = null,
-    requestOptions: RequestOptions = RequestOptions(),
   ) : this(
     modelName,
     apiKey,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		{"type":"MAJOR","changes":["Keep argument positions"]}