Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create async queues within async loop #353

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

clementfarabet
Copy link
Contributor

Code doesn't run as is / crashes with queues created outside of asyncio.run().

Code doesn't run as is / crashes with queues created outside of asyncio.run().
@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Dec 15, 2024
@Giom-V Giom-V requested review from markmcd and MarkDaoust December 15, 2024 23:06
@clementfarabet
Copy link
Contributor Author

For context, error without this change:

RuntimeError: Task <Task pending name='Task-8' coro=<AudioLoop.send_frames() running at /Users/clmt/workspace/cookbook/gemini-2/live_api_starter.py:107> cb=[_TaskGroup._on_task_done(), AudioLoop.run.<locals>.check_error() at /Users/clmt/workspace/cookbook/gemini-2/live_api_starter.py:194]> got Future <Future pending> attached to a different loop

Copy link
Contributor

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks like this depends on pythion version and we hadn't tested some of the older ones.

@MarkDaoust MarkDaoust merged commit a7c488d into google-gemini:main Dec 16, 2024
3 checks passed
@clementfarabet
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants