Fix: Convert BGR to RGB color space for correct video colors #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added cv2.cvtColor conversion before PIL processing - Fixes blue tint issue in video feed - Ensures correct color representation in Gemini 2.0 Live API video feed - Added explanatory comments for future maintainers Issue: Video feed shows blue tint due to BGR/RGB colorspace mismatch Solution: Convert OpenCV BGR output to RGB before PIL processing
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
the
status:awaiting review
|
/check-cla |
markmcd
approved these changes
Dec 12, 2024
|
Wow this is my first contribution ever! I am a Youtuber who learnt coding entirely from Gemini I made into a cool quirky coding professor and I've learning from it for about a year now! And learnt flutter and now creating a really cool app! I am a filmmaker and a musician from Egypt, and I would love to like just show you guys the amazing crazy stuff I built that combines my unique Egyptian Arabic background with all your a.i tools!
PS: thanks again for approving my fix!
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Mark McDonald ***@***.***>
Sent: Thursday, December 12, 2024 12:39:45 AM
To: google-gemini/cookbook ***@***.***>
Cc: Mohamed Essawi ***@***.***>; Author ***@***.***>
Subject: Re: [google-gemini/cookbook] Fix: Convert BGR to RGB color space for correct video colors (PR #338)
@markmcd approved this pull request.
Fantastic - thanks for the fix!
—
Reply to this email directly, view it on GitHub<#338 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BAUEKXSUCSH5Z3NHWSN4LQD2FFDVDAVCNFSM6AAAAABTPHKIJ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOJYGM2DAOBWGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
/check-cla |
|
Thanks @robotlovehuman. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video Feed Color Correction
Issue
Fix
Testing
Technical Details