Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point gemini-1.5-flash-latest as default model for all quickstart notebooks #173

Closed
wants to merge 4 commits into from

Conversation

lucianommartins
Copy link
Contributor

Make gemini-1.5-flash-latest as the default model for all quickstart notebooks.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:quickstarts Issues/PR referencing quickstarts folder labels May 24, 2024
@@ -175,7 +175,7 @@
"outputs": [],
Copy link
Contributor

@MarkDaoust MarkDaoust May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be genai.get_model('models/gemini-1.5-flash-latest')


Reply via ReviewNB

@@ -43,16 +43,29 @@
{
Copy link
Contributor

@MarkDaoust MarkDaoust May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.        if chunk.text:

There are a few ways this can go wrong, and this only covers one of them.


Reply via ReviewNB

Copy link
Contributor

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to decide what our policy is here: do we save notebooks with outputs or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:quickstarts Issues/PR referencing quickstarts folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants